Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] QR code quite zone #3

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

rylydou
Copy link
Contributor

@rylydou rylydou commented Sep 10, 2023

Amazing work on this extension! I've been trying to find a qr code plugin that actually works for a while now. Before this I tried using a modified version of this addon for the a little bit but it was super buggy.

This PR adds padding support for the qr code texture. The padding is based on module_px_size. The color uses the light_module_color.

Here's what a padding size of 1 looks like:
image

I can't figure out how to get the inspector to only allow positive numbers and zero. I tried editor_hint: '0,1,or_greater' but it doesn't seam to work.

@rylydou
Copy link
Contributor Author

rylydou commented Sep 10, 2023

Oops turns out my commits aren't signed I need to fix that.

@IceflowRE
Copy link
Member

Thank you for the suggestion!
The correct term you are looking for is quiet_zone, by default it should be 4 (Chapter 6.3.8)

If you are are ready, that i can review this PR, just ping me.

@IceflowRE
Copy link
Member

If possible could you remove the spaces inside the brackets in the commit message? thanks.

@IceflowRE IceflowRE added the cat:enhancement enhancement/requested feature/update of existing features label Sep 10, 2023
@rylydou rylydou changed the title [ Feature ] QR code padding [Feature] QR code padding Sep 10, 2023
@rylydou rylydou changed the title [Feature] QR code padding [Feature] QR code quite zone Sep 10, 2023
@rylydou
Copy link
Contributor Author

rylydou commented Sep 10, 2023

I renamed the properties and I figured out how to block negative values from being entered. The default is still 1 but there is a tool tip explaining that 4 is recommend by the standard. (Feel free to change it to 4 if you want)

I'm not sure if I can rename the older commits but when you merge this PR you I think it will get squashed. (I'm still a git noob apparently)

README.md Outdated Show resolved Hide resolved
addons/qr_code/qr_code.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code_rect.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code_rect.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code_rect.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code_rect.gd Outdated Show resolved Hide resolved
addons/qr_code/qr_code_rect.gd Outdated Show resolved Hide resolved
@IceflowRE
Copy link
Member

I'm not sure if I can rename the older commits but when you merge this PR you I think it will get squashed. (I'm still a git noob apparently)

Yes sure, just edit them, or make your changes, squash yourself, rename the squashed commit and force push to your branch.

@IceflowRE IceflowRE merged commit cecb20a into kenyoni-software:main Sep 11, 2023
1 check passed
@IceflowRE
Copy link
Member

Thanks for the contribution! It is a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement enhancement/requested feature/update of existing features
Development

Successfully merging this pull request may close these issues.

2 participants