-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] QR code quite zone #3
Conversation
Oops turns out my commits aren't signed I need to fix that. |
Thank you for the suggestion! If you are are ready, that i can review this PR, just ping me. |
If possible could you remove the spaces inside the brackets in the commit message? thanks. |
I renamed the properties and I figured out how to block negative values from being entered. The default is still 1 but there is a tool tip explaining that 4 is recommend by the standard. (Feel free to change it to 4 if you want) I'm not sure if I can rename the older commits but when you merge this PR you I think it will get squashed. (I'm still a git noob apparently) |
Yes sure, just edit them, or make your changes, squash yourself, rename the squashed commit and force push to your branch. |
16f9976
to
548703a
Compare
Thanks for the contribution! It is a nice addition. |
Amazing work on this extension! I've been trying to find a qr code plugin that actually works for a while now. Before this I tried using a modified version of this addon for the a little bit but it was super buggy.
This PR adds padding support for the qr code texture. The padding is based on
module_px_size
. The color uses thelight_module_color
.Here's what a padding size of 1 looks like:
I can't figure out how to get the inspector to only allow positive numbers and zero. I tried
editor_hint: '0,1,or_greater'
but it doesn't seam to work.