New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad stop condition in Lua dijkstra #542

Open

xopxe opened this issue May 3, 2021 · 1 comment

xopxe commented May 3, 2021

In https://github.com/kennyledet/Algorithm-Implementations/blob/master/Dijkstra%27s_Shortest_Path/Lua/Yonaba/dijkstra.lua lines 84 and 85 seems to be reversed.

    if u == target then return backtrace(u) end
    if u.distance == math.huge then break end

As it is, you can detect a target arrival through a non-existing link.

Owner

kennyledet commented Dec 5, 2021

@Yonaba May you confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment