Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vertex array is not required in NFA class (Thompson Construction Algorithm) #537

Open
keshav2010 opened this issue May 3, 2019 · 1 comment
Open

vertex array is not required in NFA class (Thompson Construction Algorithm) #537

keshav2010 opened this issue May 3, 2019 · 1 comment

Comments

@keshav2010
Copy link

keshav2010 commented May 3, 2019 •
edited
Loading

Why are we creating an array of vertices ? i think we can simply have an int to keep track of number of vertices within a NFA. In case im wrong or missing out something, please do let me know.
Link To Code
@keshav2010 keshav2010 changed the title vertex array is not required in NFA class vertex array is not required in NFA class (Thompson Construction Algorithm) May 3, 2019
@kennyledet
Copy link
Owner

How's it going keshav,

This was implemented by our contributor @AlexMathew, but back in 2014. You're more than welcome to update on top of this and contribute an optimized implementation!

Best,
Kendrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennyledet @keshav2010