From 7cb53ec9944b19ed5ba92b2466e73fc158ef1d11 Mon Sep 17 00:00:00 2001
From: Pierre Cavin <me@sherlox.io>
Date: Sun, 29 Oct 2023 18:30:06 +0100
Subject: [PATCH] fix: revert runOnce breaking changes (#760)

---
 src/job.ts  | 11 +++++++----
 src/time.ts |  4 ++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/job.ts b/src/job.ts
index e89b1377..b1d8be75 100644
--- a/src/job.ts
+++ b/src/job.ts
@@ -16,15 +16,12 @@ export class CronJob<OC extends CronOnCompleteCommand | null = null, C = null> {
 	running = false;
 	unrefTimeout = false;
 	lastExecution: Date | null = null;
+	runOnce = false;
 	context: CronContext<C>;
 	onComplete?: WithOnComplete<OC> extends true
 		? CronOnCompleteCallback
 		: undefined;
 
-	get runOnce(): boolean {
-		return this.cronTime.realDate;
-	}
-
 	private _timeout?: NodeJS.Timeout;
 	private _callbacks: CronCallback<C, WithOnComplete<OC>>[] = [];
 
@@ -87,6 +84,10 @@ export class CronJob<OC extends CronOnCompleteCommand | null = null, C = null> {
 			) as WithOnComplete<OC> extends true ? CronOnCompleteCallback : undefined;
 		}
 
+		if (this.cronTime.realDate) {
+			this.runOnce = true;
+		}
+
 		this.addCallback(this._fnWrap(onTick));
 
 		if (runOnInit) {
@@ -178,10 +179,12 @@ export class CronJob<OC extends CronOnCompleteCommand | null = null, C = null> {
 		if (!(time instanceof CronTime)) {
 			throw new CronError('time must be an instance of CronTime.');
 		}
+
 		const wasRunning = this.running;
 		this.stop();
 
 		this.cronTime = time;
+		if (time.realDate) this.runOnce = true;
 
 		if (wasRunning) this.start();
 	}
diff --git a/src/time.ts b/src/time.ts
index 9814c630..3f4e74a3 100644
--- a/src/time.ts
+++ b/src/time.ts
@@ -84,7 +84,7 @@ export class CronTime {
 		return date.weekday === 7 ? 0 : date.weekday;
 	}
 
-	/*
+	/**
 	 * Ensure that the syntax parsed correctly and correct the specified values if needed.
 	 */
 	private _verifyParse() {
@@ -762,7 +762,7 @@ export class CronTime {
 			}
 		});
 
-		// * is a shortcut to [low-high] range for the field
+		// "*" is a shortcut to [low-high] range for the field
 		value = value.replace(RE_WILDCARDS, `${low}-${high}`);
 
 		// commas separate information, so split based on those