Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up top-level directories #2

Open
0xCryptoSheik opened this issue Mar 21, 2022 · 0 comments
Open

clean up top-level directories #2

0xCryptoSheik opened this issue Mar 21, 2022 · 0 comments

Comments

@0xCryptoSheik
Copy link

Hey @staccDOTsol,

At the moment, this repository contains 4 top-level directories:

  • curl-demo
  • mango-bowl
  • mango-service-v3
  • opportunities-assessor
  • py

Few observations:

  • All top-level directories that aren't strictly necessary should be removed (curl-demo ?).
  • the py directory I assume contains the main project source code, it should have a more explicit name like src
  • mango-bowl, mango-service-v3 & opportunities-assessor I assume are 3rd party dependencies.
    • 3rd party dependencies should not be present in this repository but instead be retrieved from their respective repositories or package managers.
    • if removing 3rd party dependencies from this repository is too troublesome, they should at least be documented as such in the README.
    • it appears opportunities-assessor is in fact "Mango v3 Client Library", then it should be at least named mango-v3-client-library or similar for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant