Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install does not install requirements #58

Open
davidedelvento opened this issue Apr 14, 2024 · 4 comments
Open

pip install does not install requirements #58

davidedelvento opened this issue Apr 14, 2024 · 4 comments

Comments

@davidedelvento
Copy link

And if image_registration is installed on a clear slate, it fails by not finding (e.g.) matplotlib and pytest (which as mentioned in #16 should be made optional, even though I'm fine with them being required)

keflavich added a commit that referenced this issue Apr 14, 2024
@keflavich
Copy link
Owner

The installation requirements are specified in setup.cfg. I added matplotlib here: 8df26a7. pytest... shouldn't be required to load image_registration? If it is, again, that should be factored out.

@keflavich
Copy link
Owner

ok, I see pytest is also incorrectly required. Thanks for noting that.

@keflavich
Copy link
Owner

fixed pytest requirement in a47d247. It can't easily be factored out; @pytest.mark is needed at import time.

@davidedelvento
Copy link
Author

Sounds good. The bug report was based on the version published on PyPI, perhaps that was released before 8df26a7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants