Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decipher/Cipher links not correct when URL not traditional #23

Open
zlacelle opened this issue Apr 24, 2015 · 2 comments
Open

Decipher/Cipher links not correct when URL not traditional #23

zlacelle opened this issue Apr 24, 2015 · 2 comments
Labels
enhancement

Comments

@zlacelle
Copy link

We're running redmine at https://redmine.company.com/redmine, not just at https://redmine.company.com. When we try to encode/decode, the URL gets rewritten incorrectly. For example: https://redmine.company.com/redmine/projects/testproject/wiki gets rewritten to https://redmine.company.com/projects/testproject/wiki.
@hsilva-keep
Copy link
Member

Dear @zlacelle
First of all, thank you for your feedback. And yes, we kind of have that URL creation hard-coded for a Redmine deployment in / (not suitable for other deployments).

So, as soon as we have the opportunity/time, we will fix that and let you know. OR, if you wish to, you can provide a fix by submitting a pull request, which we will happily review and integrate with the base code.

@zlacelle
Copy link
Author

Great, thanks for replying. I just changed the hardcoded value, but I'll see if I can learn a bit of Ruby and come up with a fix.

paulvt added a commit to LeftClickBV/redmine_wikicipher that referenced this issue Aug 10, 2016
@paulvt
Fix generation of cipher/decipher URLs
eb3c348 
This solves the issue where the cipher/decipher button cannot be used if
Redmine is not deployed on the root URL (see also keeps#23).

In case of Redmine 2.x, Redmine::Utils.relative_url_root needs to be
prefixed, as it is not a port of the *_path URLs yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zlacelle @hsilva-keep