-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify _split_params
to handle a list
#4205
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
I get this error when I do |
…eing click..) Signed-off-by: Merel Theisen <[email protected]>
You're right.. I think this is annoying |
Signed-off-by: Merel Theisen <[email protected]>
I am still getting
Would this be equivalent to |
Hmm... 🤔 The use case is in VertexAI it wraps parameters in a list before passing them on. The run command is called slightly different from when it's called through the CLI from what I could see during the walkthrough. I don't know how hard it is to test this properly on VertexAI, but I can ask the client if they want to test it from the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@noklam I've played around with Vertex, but since the client team has a custom setup it's hard for me to replicate and test it fully. I've contacted them, but they can't install directly from the branch. Would you be okay with merging and releasing this so they can use it more easily? Or do you still have concerns about the solution? |
On the testing side:
On the PR itself, the use case is still a bit mysterious to me. If it's a VertexAI specific thing, why do it need to go in to kedro instead of a plugin, or From what I have seen in the test, it is different from what get actually run in For example: |
Description
A client team using Kedro was facing issues with their deployment flow with VertexAI. They managed to workaround most of it, but mentioned their workflow would be simplified if it's possible to pass runtime parameters within a list, because that's how Vertex wraps parameters.
Development notes
Allow parameters to wrapped in a list like
--params ["key1=a,key2=b"]
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file