-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make kedro viz run --pipeline
consistent with kedro run --pipeline
#1754
Comments
More context in the linked issue. Essentially, spaces are valid for pipeline names in Kedro Viz, but not for Kedro Framework. So I liberally opened this on Kedro Viz, seemingly implying that Viz should converge with Framework. But maybe it should be the other way around? (: |
@astrojuanlu - do we need to do work on Kedro-Viz, or will this be a Kedro framework ticket then? |
It's for us to decide what to do cc @merelcht |
We'll need to have a look at what consistency between the CLI on Framework and Viz means. Is this the only command with inconsistency? And how do other similar arguments get treated on the Framework side? Maybe changing this to be consistent with Viz would mean breaking consistency with how things are done across the CLI on Framework. |
We discuss this ticket when @astrojuanlu has a chance to look at this more closely. |
Can we do with this issue the same we did with kedro-org/kedro#2259 ? Hence reframe it to "look for inconsistencies between Kedro and Kedro-Viz", prioritise it as low, and move it to the backlog. |
@rashidakanchwala to create an issue on highlighting inconsistencies between kedro cli and kedro-viz cli. |
Closing this ticket in favour of this #2165 |
Originally posted by @astrojuanlu in #1733 (comment)
The text was updated successfully, but these errors were encountered: