Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kedro viz run --pipeline consistent with kedro run --pipeline #1754

Closed
astrojuanlu opened this issue Feb 15, 2024 · 8 comments
Closed

Comments

@astrojuanlu
Copy link
Member

I think kedro viz run --pipeline should be consistent with how kedro run --pipeline behaves. This behavior was surprising also for me.

Originally posted by @astrojuanlu in #1733 (comment)

@astrojuanlu
Copy link
Member Author

More context in the linked issue. Essentially, spaces are valid for pipeline names in Kedro Viz, but not for Kedro Framework. So kedro run --pipeline="Reporting stage" would not work, but kedro viz run --pipeline="Reporting stage" does.

I liberally opened this on Kedro Viz, seemingly implying that Viz should converge with Framework. But maybe it should be the other way around? (:

@rashidakanchwala
Copy link
Contributor

@astrojuanlu - do we need to do work on Kedro-Viz, or will this be a Kedro framework ticket then?

@astrojuanlu
Copy link
Member Author

It's for us to decide what to do cc @merelcht

@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Mar 11, 2024
@merelcht
Copy link
Member

We'll need to have a look at what consistency between the CLI on Framework and Viz means. Is this the only command with inconsistency? And how do other similar arguments get treated on the Framework side? Maybe changing this to be consistent with Viz would mean breaking consistency with how things are done across the CLI on Framework.

@rashidakanchwala rashidakanchwala moved this from Backlog to Inbox in Kedro-Viz Jul 29, 2024
@rashidakanchwala
Copy link
Contributor

We discuss this ticket when @astrojuanlu has a chance to look at this more closely.

@astrojuanlu
Copy link
Member Author

Can we do with this issue the same we did with kedro-org/kedro#2259 ? Hence reframe it to "look for inconsistencies between Kedro and Kedro-Viz", prioritise it as low, and move it to the backlog.

@rashidakanchwala
Copy link
Contributor

@rashidakanchwala to create an issue on highlighting inconsistencies between kedro cli and kedro-viz cli.

@rashidakanchwala
Copy link
Contributor

Closing this ticket in favour of this #2165

@rashidakanchwala rashidakanchwala closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in Kedro-Viz Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants