Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Extra KCL top level arguments for kio.Pipeline. #26

Closed
Peefy opened this issue Jan 5, 2024 · 3 comments · Fixed by #59
Closed

[Enhancement] Support Extra KCL top level arguments for kio.Pipeline. #26

Peefy opened this issue Jan 5, 2024 · 3 comments · Fixed by #59
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Peefy
Copy link
Contributor

Peefy commented Jan 5, 2024

No description provided.

@Peefy Peefy added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2024
@Peefy Peefy added the good first issue Good for newcomers label Jan 23, 2024
@satyazzz123
Copy link
Contributor

Hello @Peefy can you give me some information about this issue about what is required . Thank you!

@Peefy
Copy link
Contributor Author

Peefy commented Jan 25, 2024

Hello @Peefy can you give me some information about this issue about what is required . Thank you!

In this issue, we need to expand the RunKCL function with more options just like:

func RunKCL(name, source string, resourceList *yaml.RNode, arguments, []string) ([]*yaml.RNode, error) {

And put the arguments into opts.Arguments at here

@d4v1d03
Copy link
Contributor

d4v1d03 commented Apr 21, 2024

Hey @Peefy , can you pls assign me this issue, i want to work on it.

@Peefy Peefy mentioned this issue May 7, 2024
2 tasks
@Peefy Peefy closed this as completed in #59 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants