-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with recursive download #13
Comments
This is a record type I've never seen before, and it looks like Biopython doesn't like it. I'll open a bug report with Biopython to get it fixed, and then I can make sure ncbi-acc-download supports it. |
Thank you so much for your quick response. Any possible help in this regard would really make my day |
I've opened a Biopython bug biopython/biopython#2268, let's see what they think about this. |
Thanks; fingers crossed! Also, how to get the fasta file for this record on recursive mode? For example, I tried the below and I get an empty fasta file: ncbi-acc-download --recursive NZ_AQZU00000000.1 --format fasta ncbi-acc-download --recursive NZ_AQZU00000000.1 does appear to give me the correct .gbk file |
Hm, I think I've never tried this for FASTA files. I don't think it'll work out of the box. |
Thanks again for your super-quick responses. I think I can live with .gbk files for now :-) |
Hi, I was wondering if you have managed to find any sort of fix for "ncbi-acc-download --recursive GHGH00000000.1"? My intention is certainly not to push you here but I would be very grateful for any new pointers. |
This will only be fixed once Biopython 1.75 is released, as that contains a fix for the problem. |
Many thanks for your response. I will await the release of Biopython 1.75. |
End of year cleaning of old issues. This one should be fixed by current Biopython versions. |
Thank you so much for remembering to follow up with this- much appreciated! I would like to report that although there are no error messages being output now after the biopython upgrade, the command ncbi-acc-download --recursive GHGH00000000.1 merely downloads the master record gbk file and not all of the records that are covered by the master record. Unfortunately, the purpose of having 'recursive' doesn't seem to be served here. |
Thanks for testing. I'll have a look at this. |
Ah, shoot, it looks like there's still an issue in the Biopython support for this. 😞 We need biopython/biopython#2432 to land and be shipped first. And I think I still need a change in ncbi-acc-download as well. |
This feature will only work with the current Biopython master branch. Once Biopython 1.77 is released, this feature should work for regular installs. Fixes issue #13. Signed-off-by: Kai Blin <[email protected]>
Ok, another try. Once Biopython releases 1.77, 789a34b should have fixed it. Install the 0.2.6 version of |
Many thanks for the update; once biopython 1.77 is out, I'll give a try with ncbi-acc-download v0.2.6 |
I tried ncbi-acc-download --recursive GHGH00000000.1 and I got the below error message. Any help here would be very much appreciated.
Traceback (most recent call last):
File "/home/user/tools/Python-3.6.2/virtualenv3/bin/ncbi-acc-download", line 10, in
sys.exit(main())
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/ncbi_acc_download/main.py", line 54, in main
download_to_file(dl_id, config, filename, append)
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/ncbi_acc_download/core.py", line 118, in download_to_file
_validate_and_write(r, fh, dl_id, config)
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/ncbi_acc_download/core.py", line 162, in _validate_and_write
downloaded = download_wgs_parts(handle, config)
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/ncbi_acc_download/wgs.py", line 107, in download_wgs_parts
records = list(SeqIO.parse(handle, config.format))
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/Bio/SeqIO/init.py", line 655, in parse
for r in i:
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/Bio/GenBank/Scanner.py", line 489, in parse_records
record = self.parse(handle, do_features)
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/Bio/GenBank/Scanner.py", line 473, in parse
if self.feed(handle, consumer, do_features):
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/Bio/GenBank/Scanner.py", line 445, in feed
self._feed_feature_table(consumer, self.parse_features(skip=False))
File "/home/user/tools/Python-3.6.2/virtualenv3/lib/python3.6/site-packages/Bio/GenBank/Scanner.py", line 171, in parse_features
raise ValueError("Premature end of features table, marker '//' found")
ValueError: Premature end of features table, marker '//' found
The text was updated successfully, but these errors were encountered: