Merge pull request rdkcentral#8 from gururaajar/develop

RDKTV-33219, XIONE-15762 - [RDKE] GetIPSettings without input arg is failing
karuna2git · Sep 19, 2024 · e366a6a · e366a6a
2 parents 0465aea + fd9e807
commit e366a6a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/NetworkManagerJsonRpc.cpp b/NetworkManagerJsonRpc.cpp
@@ -285,7 +285,7 @@ namespace WPEFramework
             if (parameters.HasLabel("ipversion"))
                 ipversion = parameters["ipversion"].String();
 
-            if ("wlan0" != interface && "eth0" != interface)
+            if (!interface.empty() && ("wlan0" != interface) && ("eth0" != interface))
             {
                 rc = Core::ERROR_BAD_REQUEST;
                 return rc;

diff --git a/docs/NetworkManagerPlugin.md b/docs/NetworkManagerPlugin.md
@@ -367,7 +367,7 @@ No Events
 | Name | Type | Description |
 | :-------- | :-------- | :-------- |
 | params | object |  |
-| params.interface | string | An interface, such as `eth0` or `wlan0`, depending upon availability of the given interface |
+| params.interface | string | <sup>*(optional)*</sup> An interface, such as `eth0` or `wlan0`, depending upon availability of the given interface. If this is empty, default interface will be returned |
 | params?.ipversion | string | <sup>*(optional)*</sup> either IPv4 or IPv6 |
 
 ### Result