Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectrum shouldn't be a dependency #2

Open
clemera opened this issue Apr 29, 2020 · 1 comment
Open

Selectrum shouldn't be a dependency #2

clemera opened this issue Apr 29, 2020 · 1 comment

Comments

@clemera
Copy link

clemera commented Apr 29, 2020

Selectrum tries to be completing API compliant would you consider using completing-read instead?

@raxod502
Copy link

raxod502 commented May 1, 2020

It's sweet that people are already making packages built on my work. I do agree that a dependency should be avoided if possible, however. In this case, the dependency is because of the use of selectrum-candidate-display-right-margin. @kamoii you can always apply the text property, but use completing-read instead of selectrum-read. That way, your package works for everyone, and people who use Selectrum get a little extra annotation which can't be supported by completing-read. Just one idea, I am sure there are other approaches too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants