경북대_Android_이혜원 1주차 과제 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
step1 : 연락처 추가 실행모습입니다! <gif 사진입니다>
|
Han961004
added a commit
to Han961004/android-contacts
that referenced
this pull request
Jun 27, 2024
|
step2 : 기능요구사항
조금 더 코드를 고친후에, 스크롤 구현을 해보겠습니다.. step2 : 실행화면 gif |
|
<뒤로가기시 팝업창 뜨기 구현화면 입니다.!> 
|
acious
approved these changes
Jun 30, 2024
Comment on lines
+40
to
+41
| viewBinding = true | ||
| dataBinding = true |
Comment on lines
+7
to
+17
| class ContactViewModel : ViewModel() { | ||
| val contactListLiveData = MutableLiveData<MutableList<contact>>().apply { | ||
| value = ContactList | ||
| } | ||
|
|
||
| fun addContact(contact: contact) { | ||
| ContactList.add(contact) | ||
| contactListLiveData.value = ContactList | ||
| Log.d("ContactViewModel", "Contact added: ${contact.name}, total contacts: ${ContactList.size}") | ||
| } | ||
| } |
| setContentView(binding.root) | ||
|
|
||
| // Intent로부터 데이터를 받아와서 UI에 설정 | ||
| val name = intent.getStringExtra("name") |
There was a problem hiding this comment.
보통 이런 요소는 Constant라는 object를 파일단위로 생성하고
const val NAV_KEY_NAME= name" 을 변수로 세팅하여 사용합니다.
그리고 받는쪽에서도 이것을 사용하는거죠.
| val phoneNumber = intent.getStringExtra("phoneNumber") ?: "" | ||
|
|
||
| if (name.isNotEmpty() && phoneNumber.isNotEmpty()) { | ||
| Log.d("ListActivity", "New contact: $name, $phoneNumber") |
Comment on lines
+19
to
+26
| val nameEdit: EditText = findViewById(R.id.NameEdit) | ||
| val phoneNumberEdit: EditText = findViewById(R.id.PhoneNumberEdit) | ||
| val moreText: TextView = findViewById(R.id.MoreText) | ||
| val birthEdit: EditText = findViewById(R.id.BirthEdit) | ||
| val memoEdit: EditText = findViewById(R.id.MemoEdit) | ||
| val genderArea: LinearLayoutCompat = findViewById(R.id.GenderArea) | ||
| val saveText: TextView = findViewById(R.id.SaveText) | ||
| val cancelText: TextView = findViewById(R.id.CancleText) |
There was a problem hiding this comment.
메소드를 실행시킬때마다 비싼 xml 파싱을 통해 뷰를 탐색해내는 findViewBy 를 실행하는 것이 아닌,
액티비티가 열렸을때 one-time만 이것들을 호출하여 필드 인스턴스를 할당하고 그것을 계속 재사용하는게 성능측면에서 더 좋아보입니다.
| android:layout_weight="3" | ||
| android:textAlignment="center" | ||
| android:textSize="20dp" | ||
| android:text="오른쪽 + 버튼을 클릭하여\n 연락처를 등록해보세요." |
There was a problem hiding this comment.
String은 추후에 영어등의 다른 언어로 번역해서 쓰일수있으니 strings.xml에서 관리하는게 어떨까요?
acious
reviewed
Jun 30, 2024
| val phoneNumber = phoneNumberEdit.text.toString().trim() | ||
|
|
||
| if (name.isEmpty()) { | ||
| Toast.makeText(this@MainActivity, "이름은 필수값입니다.", Toast.LENGTH_SHORT).show() |
acious
reviewed
Jun 30, 2024
Comment on lines
+46
to
+51
| val intent = Intent(this, ListActivity::class.java).apply { | ||
| putExtra("name", name) | ||
| putExtra("phoneNumber", phoneNumber) | ||
| } | ||
| startActivity(intent) | ||
| finish() |
There was a problem hiding this comment.
navigateToContactListView() 이런 함수로 감싸는것도 좋아보이네요.
acious
approved these changes
Jul 1, 2024
kold-brewed
pushed a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.