From 67263d9025ccf7b31e242184f73853ea9c658ff8 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Tue, 3 Oct 2023 16:43:50 -0700 Subject: [PATCH 01/20] fix: new dockerfile for llama image building --- docker/presets/falcon/Dockerfile | 2 +- docker/presets/llama-2-chat/Dockerfile | 12 --------- docker/presets/llama-2/Dockerfile | 35 +++++++++++++++++++++++++- 3 files changed, 35 insertions(+), 14 deletions(-) delete mode 100644 docker/presets/llama-2-chat/Dockerfile diff --git a/docker/presets/falcon/Dockerfile b/docker/presets/falcon/Dockerfile index d251a4e0e..27428c90f 100644 --- a/docker/presets/falcon/Dockerfile +++ b/docker/presets/falcon/Dockerfile @@ -2,7 +2,7 @@ FROM nvcr.io/nvidia/pytorch:23.06-py3 # Set the working directory -WORKDIR /workspace/huggingface +WORKDIR /workspace/falcon # First, copy just the requirements.txt file and install dependencies # This is done before copying the code to utilize Docker's layer caching and diff --git a/docker/presets/llama-2-chat/Dockerfile b/docker/presets/llama-2-chat/Dockerfile deleted file mode 100644 index e91966a16..000000000 --- a/docker/presets/llama-2-chat/Dockerfile +++ /dev/null @@ -1,12 +0,0 @@ -FROM nvcr.io/nvidia/pytorch:23.06-py3 -WORKDIR /workspace - -RUN git clone https://github.com/facebookresearch/llama - -WORKDIR /workspace/llama - -RUN pip install -e . -RUN pip install fastapi pydantic -RUN pip install 'uvicorn[standard]' - -ADD pkg/presets/llama-2-chat /workspace/llama/llama-2-chat diff --git a/docker/presets/llama-2/Dockerfile b/docker/presets/llama-2/Dockerfile index a68f56df9..40285b436 100644 --- a/docker/presets/llama-2/Dockerfile +++ b/docker/presets/llama-2/Dockerfile @@ -1,3 +1,15 @@ +# Build text completion model +# docker build \ +# --build-arg LLAMA_VERSION=llama-2-7b \ +# --build-arg SRC_DIR=pkg/presets/llama-2 \ +# -t llama-2-7b:latest . + +# Build chat completion model +# docker build \ +# --build-arg LLAMA_VERSION=llama-2-7b-chat \ +# --build-arg SRC_DIR=pkg/presets/llama-2-chat \ +# -t llama-2-7b-chat:latest . + FROM nvcr.io/nvidia/pytorch:23.06-py3 WORKDIR /workspace @@ -9,4 +21,25 @@ RUN pip install -e . RUN pip install fastapi pydantic RUN pip install 'uvicorn[standard]' -ADD pkg/presets/llama-2 /workspace/llama/llama-2 +ARG LLAMA_VERSION +ARG SRC_DIR + +# Conditional logic based on LLAMA_VERSION argument +RUN if [ "$LLAMA_VERSION" = "llama-2-7b" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + elif [ "$LLAMA_VERSION" = "llama-2-13b" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + elif [ "$LLAMA_VERSION" = "llama-2-70b" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + elif [ "$LLAMA_VERSION" = "llama-2-7b-chat" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + elif [ "$LLAMA_VERSION" = "llama-2-13b-chat" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + elif [ "$LLAMA_VERSION" = "llama-2-70b-chat" ]; then \ + wget -P ${SRC_DIR}/weights ; \ + else \ + echo "Invalid or missing LLAMA_VERSION"; \ + exit 1; \ + fi + +ADD ${SRC_DIR} /workspace/llama/llama-2 From 06a6355d6cfa86495f8e3c075125db32abd6af3c Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Tue, 3 Oct 2023 17:40:36 -0700 Subject: [PATCH 02/20] feat: added github action for build and deploy image --- .github/workflows/preset-image-build.yml | 49 ++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/workflows/preset-image-build.yml diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml new file mode 100644 index 000000000..708da6430 --- /dev/null +++ b/.github/workflows/preset-image-build.yml @@ -0,0 +1,49 @@ +name: Build and Push Models + +on: + pull_request: + branches: [main] + paths: + - 'pkg/presets/falcon/**' + - 'pkg/presets/llama-2/**' + - 'pkg/presets/llama-2-chat/**' + +jobs: + build-and-push: + runs-on: ubuntu-20.04 + steps: + - name: Checkout + uses: actions/checkout@v2 + + - uses: azure/login@v1.4.7 + with: + client-id: ${{ secrets.AZURE_CLIENT_ID }} + tenant-id: ${{ secrets.AZURE_TENANT_ID }} + subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} + + - name: Install Azure CLI latest + run: | + curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash + az account set --subscription ${{ secrets.SUBSCRIPTION_ID }} + + - name: Set Image Tag + run: echo "IMAGE_TAG=$(git rev-parse --short HEAD)" >> $GITHUB_ENV + + # Build and push falcon model if required + - name: Build and push Falcon model + if: contains(github.event.pull_request.labels.*.name, 'pkg/presets/falcon') + run: | + cd docker/presets/falcon + az acr build -t aimodelsregistry.azurecr.io/falcon:${{ env.IMAGE_TAG }} -r aimodelsregistry . + + # Build and push llama models if required + - name: Build and push Llama models + if: contains(github.event.pull_request.labels.*.name, 'pkg/presets/llama-2') || contains(github.event.pull_request.labels.*.name, 'pkg/presets/llama-2-chat') + run: | + for model in llama-2-7b llama-2-13b llama-2-70b; do + az acr build --build-arg LLAMA_VERSION=$model --build-arg SRC_DIR=pkg/presets/llama-2 -t aimodelsregistry.azurecr.io/$model:${{ env.IMAGE_TAG }} -r aimodelsregistry . + done + for model in llama-2-7b-chat llama-2-13b-chat llama-2-70b-chat; do + az acr build --build-arg LLAMA_VERSION=$model --build-arg SRC_DIR=pkg/presets/llama-2-chat -t aimodelsregistry.azurecr.io/$model:${{ env.IMAGE_TAG }} -r aimodelsregistry . + done + From 999518b3c9cb66eb045d8206bdee51525363c9d5 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Tue, 3 Oct 2023 18:11:31 -0700 Subject: [PATCH 03/20] fix: fix az login --- .github/workflows/preset-image-build.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 708da6430..7e248d8ff 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -1,4 +1,4 @@ -name: Build and Push Models +name: Build and Push Preset Models on: pull_request: @@ -15,16 +15,14 @@ jobs: - name: Checkout uses: actions/checkout@v2 - - uses: azure/login@v1.4.7 + - uses: azure/login@v1 with: - client-id: ${{ secrets.AZURE_CLIENT_ID }} - tenant-id: ${{ secrets.AZURE_TENANT_ID }} - subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} + creds: ${{ secrets.AZURE_CREDENTIALS }} - name: Install Azure CLI latest run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - az account set --subscription ${{ secrets.SUBSCRIPTION_ID }} + az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} - name: Set Image Tag run: echo "IMAGE_TAG=$(git rev-parse --short HEAD)" >> $GITHUB_ENV From d8ae6fc6ada277175f8c982e53973f944179922f Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 13:45:27 -0700 Subject: [PATCH 04/20] fix: fixed issues with git action --- .github/workflows/preset-image-build.yml | 99 ++++++++++++++++++------ 1 file changed, 77 insertions(+), 22 deletions(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 7e248d8ff..303478c4f 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -1,47 +1,102 @@ name: Build and Push Preset Models on: - pull_request: - branches: [main] + push: + branches: + - main paths: - 'pkg/presets/falcon/**' - 'pkg/presets/llama-2/**' - 'pkg/presets/llama-2-chat/**' jobs: - build-and-push: + setup: runs-on: ubuntu-20.04 + outputs: + image_tag: ${{ steps.set_tag.outputs.image_tag }} steps: - name: Checkout uses: actions/checkout@v2 - - uses: azure/login@v1 - with: - creds: ${{ secrets.AZURE_CREDENTIALS }} - - name: Install Azure CLI latest run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} + + - name: 'Az CLI login' + uses: azure/login@v1.4.7 + with: + client-id: ${{ secrets.AZURE_CLIENT_ID }} + tenant-id: ${{ secrets.AZURE_TENANT_ID }} + subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} - name: Set Image Tag - run: echo "IMAGE_TAG=$(git rev-parse --short HEAD)" >> $GITHUB_ENV + id: set_tag + run: echo "::set-output name=image_tag::$(git rev-parse --short HEAD)" - # Build and push falcon model if required + - name: 'Login to ACR' + run: az acr login --name aimodelsregistry + + falcon: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/falcon/') + steps: - name: Build and push Falcon model - if: contains(github.event.pull_request.labels.*.name, 'pkg/presets/falcon') run: | cd docker/presets/falcon - az acr build -t aimodelsregistry.azurecr.io/falcon:${{ env.IMAGE_TAG }} -r aimodelsregistry . + az acr build -t aimodelsregistry.azurecr.io/falcon:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . - # Build and push llama models if required - - name: Build and push Llama models - if: contains(github.event.pull_request.labels.*.name, 'pkg/presets/llama-2') || contains(github.event.pull_request.labels.*.name, 'pkg/presets/llama-2-chat') + llama-2-7b: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2/') + steps: + - name: Build and push Llama model run: | - for model in llama-2-7b llama-2-13b llama-2-70b; do - az acr build --build-arg LLAMA_VERSION=$model --build-arg SRC_DIR=pkg/presets/llama-2 -t aimodelsregistry.azurecr.io/$model:${{ env.IMAGE_TAG }} -r aimodelsregistry . - done - for model in llama-2-7b-chat llama-2-13b-chat llama-2-70b-chat; do - az acr build --build-arg LLAMA_VERSION=$model --build-arg SRC_DIR=pkg/presets/llama-2-chat -t aimodelsregistry.azurecr.io/$model:${{ env.IMAGE_TAG }} -r aimodelsregistry . - done - + az acr build --build-arg LLAMA_VERSION=llama-2-7b --build-arg SRC_DIR=pkg/presets/llama-2 -t aimodelsregistry.azurecr.io/llama-2-7b:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + + llama-2-13b: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2/') + steps: + - name: Build and push Llama model + run: | + az acr build --build-arg LLAMA_VERSION=llama-2-13b --build-arg SRC_DIR=pkg/presets/llama-2 -t aimodelsregistry.azurecr.io/llama-2-13b:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + + llama-2-70b: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2/') + steps: + - name: Build and push Llama model + run: | + az acr build --build-arg LLAMA_VERSION=llama-2-70b --build-arg SRC_DIR=pkg/presets/llama-2 -t aimodelsregistry.azurecr.io/llama-2-70b:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + + llama-2-7b-chat: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2-chat/') + steps: + - name: Build and push Llama chat model + run: | + az acr build --build-arg LLAMA_VERSION=llama-2-7b-chat --build-arg SRC_DIR=pkg/presets/llama-2-chat -t aimodelsregistry.azurecr.io/llama-2-7b-chat:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + + llama-2-13b-chat: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2-chat/') + steps: + - name: Build and push Llama chat model + run: | + az acr build --build-arg LLAMA_VERSION=llama-2-13b-chat --build-arg SRC_DIR=pkg/presets/llama-2-chat -t aimodelsregistry.azurecr.io/llama-2-13b-chat:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + + llama-2-70b-chat: + needs: setup + runs-on: ubuntu-20.04 + if: contains(github.event.commits[0].modified, 'pkg/presets/llama-2-chat/') + steps: + - name: Build and push Llama chat model + run: | + az acr build --build-arg LLAMA_VERSION=llama-2-70b-chat --build-arg SRC_DIR=pkg/presets/llama-2-chat -t aimodelsregistry.azurecr.io/llama-2-70b-chat:${{ needs.setup.outputs.image_tag }} -r aimodelsregistry . + \ No newline at end of file From 10a28c855953e2ac58e46f685cd16cb1f7ea8564 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 14:14:07 -0700 Subject: [PATCH 05/20] feat: add workflow dispatch release --- .github/workflows/preset-image-build.yml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 303478c4f..3e777f21f 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -8,6 +8,15 @@ on: - 'pkg/presets/falcon/**' - 'pkg/presets/llama-2/**' - 'pkg/presets/llama-2-chat/**' + workflow_dispatch: + inputs: + release: + description: 'Release (yes/no)' + required: true + default: 'no' + image_tag: + description: 'Image Tag' + required: false jobs: setup: @@ -31,7 +40,12 @@ jobs: - name: Set Image Tag id: set_tag - run: echo "::set-output name=image_tag::$(git rev-parse --short HEAD)" + run: | + if [[ "${{ github.event_name }}" == "workflow_dispatch" && -n "${{ github.event.inputs.image_tag }}" ]]; then + echo "::set-output name=image_tag::${{ github.event.inputs.image_tag }}" + else + echo "::set-output name=image_tag::$(git rev-parse --short HEAD)" + fi - name: 'Login to ACR' run: az acr login --name aimodelsregistry From 2e50d93ee73fd0cb5c9bfd4040f9e62748f02cf6 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 14:32:50 -0700 Subject: [PATCH 06/20] nit: add for testing action --- .github/workflows/preset-image-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 3e777f21f..0bf454eda 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -4,6 +4,7 @@ on: push: branches: - main + - Ishaan/auto-image-build # This line is added to trigger on pushes to your PR branch. paths: - 'pkg/presets/falcon/**' - 'pkg/presets/llama-2/**' From 5d5919790559f6ff78d5b49ff7e3e5923b48bae7 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:13:02 -0700 Subject: [PATCH 07/20] nit: testing git action --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index 508d53070..bb25abaee 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result: {seq['generated_text']}") + print(f"Result {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From b1e6c666bc84c7040939577e103650e100344145 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:16:03 -0700 Subject: [PATCH 08/20] fix: add token permissions --- .github/workflows/preset-image-build.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 0bf454eda..b6ce39c75 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -4,7 +4,7 @@ on: push: branches: - main - - Ishaan/auto-image-build # This line is added to trigger on pushes to your PR branch. + - Ishaan/auto-image-build paths: - 'pkg/presets/falcon/**' - 'pkg/presets/llama-2/**' @@ -19,6 +19,10 @@ on: description: 'Image Tag' required: false +permissions: + id-token: write + contents: read + jobs: setup: runs-on: ubuntu-20.04 From 31bdb04d2d9605d1bba51f237250444662127f55 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:16:31 -0700 Subject: [PATCH 09/20] nit: trigger falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index bb25abaee..508d53070 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result {seq['generated_text']}") + print(f"Result: {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From 6c984bbe20809b9db77767ccb40ff124e9cbff63 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:38:58 -0700 Subject: [PATCH 10/20] nit: retrigger falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index 508d53070..bb25abaee 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result: {seq['generated_text']}") + print(f"Result {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From 5ae5b6139d5b5c538d93d52b577af8a874c4e34d Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:50:44 -0700 Subject: [PATCH 11/20] fix: set subscription --- .github/workflows/preset-image-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index b6ce39c75..6e25df5ec 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -35,6 +35,7 @@ jobs: - name: Install Azure CLI latest run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash + az account set --subscription ${{ secrets.SUBSCRIPTION_ID }} - name: 'Az CLI login' uses: azure/login@v1.4.7 From 260d5b3573356625c2dfc4abd12496be9d49f0c3 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:51:37 -0700 Subject: [PATCH 12/20] nit: retrigger falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index bb25abaee..508d53070 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result {seq['generated_text']}") + print(f"Result: {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From 98b530833c122ffcc8882101ba0aba1b405c831f Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:56:33 -0700 Subject: [PATCH 13/20] nit: fix secret --- .github/workflows/preset-image-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 6e25df5ec..7e90b1a9f 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -35,7 +35,7 @@ jobs: - name: Install Azure CLI latest run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - az account set --subscription ${{ secrets.SUBSCRIPTION_ID }} + az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} - name: 'Az CLI login' uses: azure/login@v1.4.7 From 55204d7d5f7bdf0376dc51e611bf36c24dda7a19 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:57:04 -0700 Subject: [PATCH 14/20] nit: change falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index 508d53070..bb25abaee 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result: {seq['generated_text']}") + print(f"Result {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From 17b589709f1d435dfe53f929c99d636dd0a56aa3 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 15:59:47 -0700 Subject: [PATCH 15/20] nit: remove set sub --- .github/workflows/preset-image-build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 7e90b1a9f..b6ce39c75 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -35,7 +35,6 @@ jobs: - name: Install Azure CLI latest run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} - name: 'Az CLI login' uses: azure/login@v1.4.7 From a770064fdd1cab7c72ae81a3c71d25677468aad5 Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 16:00:12 -0700 Subject: [PATCH 16/20] nit: retrigger falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index bb25abaee..508d53070 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result {seq['generated_text']}") + print(f"Result: {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From e306c721f18c1e96a831070aa36b87ef543e52cc Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 16:20:26 -0700 Subject: [PATCH 17/20] nit: upgrade version --- .github/workflows/preset-image-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index b6ce39c75..4ec9e7f47 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -36,8 +36,8 @@ jobs: run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - - name: 'Az CLI login' - uses: azure/login@v1.4.7 + - name: Az CLI login + uses: azure/login@v1 with: client-id: ${{ secrets.AZURE_CLIENT_ID }} tenant-id: ${{ secrets.AZURE_TENANT_ID }} From 17af4a7d75f18a1ff61dbe7b1f2ef2a74fea84df Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 16:20:57 -0700 Subject: [PATCH 18/20] nit: retrigger falcon --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index 508d53070..bb25abaee 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result: {seq['generated_text']}") + print(f"Result {seq['generated_text']}") result += seq['generated_text'] return {"Result": result} From 2a798641e060c478a6c9ba7c118169d6f7cb41de Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 16:24:56 -0700 Subject: [PATCH 19/20] nit: fix --- .github/workflows/preset-image-build.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml index 4ec9e7f47..92b676a00 100644 --- a/.github/workflows/preset-image-build.yml +++ b/.github/workflows/preset-image-build.yml @@ -36,12 +36,11 @@ jobs: run: | curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash - - name: Az CLI login - uses: azure/login@v1 + - uses: azure/login@v1 with: client-id: ${{ secrets.AZURE_CLIENT_ID }} tenant-id: ${{ secrets.AZURE_TENANT_ID }} - subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} + allow-no-subscriptions: true - name: Set Image Tag id: set_tag From 9eb5e6213ea00895a351ca8c773066a37c79ef4e Mon Sep 17 00:00:00 2001 From: ishaansehgal99 Date: Wed, 4 Oct 2023 16:25:36 -0700 Subject: [PATCH 20/20] nit: retrigger falconm --- pkg/presets/falcon/inference-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/presets/falcon/inference-api.py b/pkg/presets/falcon/inference-api.py index bb25abaee..508d53070 100644 --- a/pkg/presets/falcon/inference-api.py +++ b/pkg/presets/falcon/inference-api.py @@ -116,7 +116,7 @@ def generate_text(params: GenerationParams): result = "" for seq in sequences: - print(f"Result {seq['generated_text']}") + print(f"Result: {seq['generated_text']}") result += seq['generated_text'] return {"Result": result}