Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Proper support for openRC in the oem layouts #511

Closed
2 tasks
Tracked by #1914 ...
mudler opened this issue Nov 30, 2022 · 5 comments
Closed
2 tasks
Tracked by #1914 ...

🌱 Proper support for openRC in the oem layouts #511

mudler opened this issue Nov 30, 2022 · 5 comments
Assignees
Labels
area/agent area/flavor refactoring Areas of code that needs refactoring, or have a technical debt

Comments

@mudler
Copy link
Member

mudler commented Nov 30, 2022

This is part of #116.

Currently we have separated system oem files for alpine: https://github.com/kairos-io/kairos/tree/master/overlay/files-alpine/system/oem .

While this works - it is harder to maintain in the context of #116, which would then require a separate workflow for alpine/openrc based systems.

This card is about:

  • Reduce separated oem files for openrc-based distro, but instead configs should detect when we are using open-rc and acting accordingly
  • Do not make anymore distinction about the flavor and init. Just use the init as a reference to detect if we have to run openRC commands or not ( e.g.
    func IsOpenRCBased() bool {
    )
@mudler mudler changed the title Unify cloud-config files across flavors Proper support for openRC Nov 30, 2022
@mudler mudler added refactoring Areas of code that needs refactoring, or have a technical debt area/agent area/flavor labels Nov 30, 2022
@mudler mudler changed the title Proper support for openRC Proper support for openRC in the oem layouts Nov 30, 2022
@mudler mudler changed the title Proper support for openRC in the oem layouts 🌱 Proper support for openRC in the oem layouts Dec 1, 2022
@mudler mudler added the good first issue Good for newcomers label Dec 19, 2022
@mauromorales mauromorales removed the good first issue Good for newcomers label Sep 26, 2023
@mauromorales
Copy link
Member

This needs to be updated to reflect the new state of the project. Layout files have been extracted to packages:

https://github.com/kairos-io/packages/tree/main/packages/static/kairos-overlay-files/files

And the go code in the kairos repo was extracted to the kairos-sdk repo: https://github.com/kairos-io/kairos-sdk/blob/8f54324703c2a88484cba31c22b8bd6b1cc26e8e/utils/utils.go#L122-L125

@jimmykarily
Copy link
Contributor

If we have this, can we have only one framework image for all flavors? Let's discuss this in the planning meeting.

@jimmykarily jimmykarily moved this to Todo 🖊 in 🧙Issue tracking board Oct 5, 2023
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Oct 5, 2023
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Oct 5, 2023
@Itxaka
Copy link
Member

Itxaka commented Oct 9, 2023

Checked and we already do this, we moved all configs to outside the kairos repo into a package and that package doesnt discriminate between flavors, is now a commo package installed during framework generation.

We are missing moving bootargs.cfg and config.txt for rpi into the generic package thougth.

@jimmykarily
Copy link
Contributor

This will be completed along with: #1465

@Itxaka
Copy link
Member

Itxaka commented Oct 20, 2023

done!

@Itxaka Itxaka closed this as completed Oct 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🏃 to Done ✅ in 🧙Issue tracking board Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent area/flavor refactoring Areas of code that needs refactoring, or have a technical debt
Projects
Archived in project
Development

No branches or pull requests

4 participants