-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add some autoreboot on UKI for failures #3041
Comments
putting this on hold. seems like it doesnt work as expected, so the testing is not possible in its current state basically:
which is weird because according to bootctl you can select entries by ID, which is the config name minus the boot assessment part, but that also doesnt work. Even when selecting it via bootctl with bootctl select-default passive.conf which does not fail adn select the proper entry, but on boot it again chooses the active entry by default even when bootctl reports the passive as the selected default entry I reported and asked about this on the systemd-devel mailing list to shed some ligth because Im baffled by this and not sure if we are doing something worng or the systemd-boot/bootctl behaviour is wrong somehow or Im just not understanding it: https://lists.freedesktop.org/archives/systemd-devel/2024-December/050993.html |
seems to be already reported upstream and this behaviour is indeed wrong: systemd/systemd#31215 |
Maybe systemd/systemd#35529 |
Gonna try applying the upstream patch directly to our bundled systemd-boot to see if we can fix th is ourselves while we wait for upstream to accept it. As it should only affect sd-boot and we control it, it may be possible |
no, the patch just breaks booting loool |
Now that we have boot assesment we would need to add some auto reboot in certain scenarios for UKI so the boot assesment is more valued.
If we boot complete with no changes and systemctl status report the system as running the current entry will be marked as GOOD and boot assesment removed from that entry
There may be some occasions in which we want to test something or validate something before it marks the entry as good.
It should be documented how to add those services and checks so users can provide their own.
A simple test could be have k3s and check that its up and running and the node is active, if not we mark dont mark the system as good and reboot
The way of doing it its explained in the https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/
requirements:
All this services should not be part of kairos itself or the framework but done as an example and added to Kairos testing if possible to test the auto assessment works as expected. Kairos itself should not be opinionated in this case, maybe on other but not on this as this is mainly an example on how to add. Adding some extra checks and auto restarts may come down the line but its not part of this ticket.
The text was updated successfully, but these errors were encountered: