-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent GRUB Configuration on .raw
images
#2980
Comments
that its correct. The idea there was that we ship ont eh raw images only the recovery partition and on boot it would run the reset and recreate the system and state partition from scratch. Im not even sure thats now running as expected so we should revisit that
we are currently on a rework of the full auroraboot, including merging thing together like enki, expanding the netboot lib to support more netboot scenarios and ship more artifacts bundled with it, so indeed the pace on versioning release should get better and indeed, the release cadence should pick up very soon (we are currently merging enki directly into aurora) and less reliant on static artifacts as you can see, we already had issues with this grub stuff in aurora and was reported to move to a more dynamic thing more than 6 months ago #2573 :) |
ok, checked out and indeed this is ok, the grub config has to point to chainload the recovery one. This is because on a raw image we only ship the oem and recovery partition and on the first boot, the reset should hit and properly setup the instace/vm/node to a proper image. It actually should override the grub values to point to the state partition once reset, so maybe we lost that part? Let me run this image in a VM and reset to check that part |
cant even reset #3025 |
Yes, the issue is likely somewhere here. Even after resetting, GRUB on EFI is still pointing to COS_RECOVERY.
Added comment to issue |
another ticket from this: #3026 |
indeed after resetting, the file still points to recovery, which is bad
|
and another ticket #3027 |
Found it! Looks like we forgot to mount the EFI partition during reset, so it would copy the proper files but not into the actual partition itself, just ot the local ephemeral dir so nothing would change. |
Does the bug affect the upgrade process? Our current workflow is as follows: raw (recovery) > reset > upgrade. However, even after completing this workflow, EFI is still pointing to COS_RECOVERY. |
IIRC upgrade does not touch the grub part, it only upgrades the active/passive/recovery so it wont touch that file at all. |
Thanks, @Itxaka. I will test it as soon as the new Kairos 3.2.x with bumped kairos-agent is released. |
Reopening until it lands on Kairos and we check the bios part as well |
bios does not need to be mounted, reset already reinstalls grub to the proper partition directly! |
Kairos version: v3.2.1
Describe the bug
I encountered an issue with TPM OOM, which was fixed much earlier than my Kairos release. When i was debugging I discovered some unexpected behavior for me with raw images. The root cause was using the latest released AuroraBoot version (
v0.2.7
) instead last:shortsha
tag , which propagates outdated GRUB files.Observations
GRUB Configuration Source for RAW images:
COS_RECOVERY
partition, notCOS_STATE
. This seems unusual, as it introduces a dependency on the recovery partition for core boot configurations.COS_RECOVERY
.Tooling Version Impact:
os-builder
.os-builder
points to:latest
packages —its last release was on Oct 4, 2023.To Reproduce
Build any raw image with the last released AuroraBoot version (not from a commit tag, but the tagged release).
Expected Behavior
There should be no dependency on tooling versions when building raw images, or tooling versions should be explicitly set in a dependency matrix.
Topics for Discussion:
COS_RECOVERY
partition correct, or should we regenerate the configuration to point toCOS_STATE
during reset/upgrade?The text was updated successfully, but these errors were encountered: