Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kairos Earthly targets should expect a base image arg only #2026

Open
Tracked by #2129
jimmykarily opened this issue Nov 27, 2023 · 2 comments
Open
Tracked by #2129

kairos Earthly targets should expect a base image arg only #2026

jimmykarily opened this issue Nov 27, 2023 · 2 comments

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Nov 27, 2023

After this is done: #1897

we should no longer call +base-image in any target. They should all require a base image to be pre-built with just docker.

After this story, our release pipelines should build the oci artifacts using only docker (no earthly).

@jimmykarily jimmykarily converted this from a draft issue Nov 27, 2023
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Nov 27, 2023
@mudler mudler mentioned this issue Dec 18, 2023
38 tasks
@mudler
Copy link
Member

mudler commented Dec 10, 2024

Is this still relevant after #3069 ?

@jimmykarily
Copy link
Contributor Author

It was meant to guarantee that no target will do anything other than converting between different types of artifacts. In other words, the base image would be built using only docker and the various earthly targets would simply generate the various artifacts from that (iso, raw images, uki, whatever)

Our current plans are:

  • Generate all types of artifacts with auroraboot (thus no earthly targets should be needed, except only if they just call auroraboot)
  • Get rid of Earthly, because it's no longer maintained (but we don't know what to replace it with exactly)
  • Have a kairos-init solution (what you linked). This only affects what we run inside the dockerfiles so it's not directly relevant to this ticket here.

All in all, I don't think we should invest much time refactoring earthly targets. After all, we won't have earthly for too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants