From 6a0827f59b1e6803684beef58f5be9eaf29226bb Mon Sep 17 00:00:00 2001
From: Itxaka <itxaka@kairos.io>
Date: Tue, 19 Sep 2023 14:48:47 +0200
Subject: [PATCH] [uki] improve spec load and spec generation

load the uki spec from the same key in the config that normal actions
generate proper disk spec for uki install

Signed-off-by: Itxaka <itxaka@kairos.io>
---
 pkg/config/spec.go | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/pkg/config/spec.go b/pkg/config/spec.go
index dc7efd2e..d046803e 100644
--- a/pkg/config/spec.go
+++ b/pkg/config/spec.go
@@ -475,20 +475,13 @@ func NewUkiInstallSpec(cfg *Config) *v1.InstallUkiSpec {
 	}
 
 	// Calculate the partitions afterwards so they use the image sizes for the final partition sizes
-	spec.Partitions = NewUkiInstallElementalPartitions(spec)
-
-	return spec
-}
-
-func NewUkiInstallElementalPartitions(spec *v1.InstallUkiSpec) v1.ElementalPartitions {
-	pt := v1.ElementalPartitions{}
-	pt.EFI = &v1.Partition{
+	spec.Partitions.BIOS = &v1.Partition{
 		FilesystemLabel: constants.EfiLabel,
-		Size:            constants.ImgSize, // TODO: Fix this
+		Size:            constants.ImgSize, // TODO: Fix this and set proper size based on the source size
 		Name:            constants.EfiPartName,
-		FS:              "fat32",
+		FS:              constants.EfiFs,
 	}
-	pt.OEM = &v1.Partition{
+	spec.Partitions.OEM = &v1.Partition{
 		FilesystemLabel: constants.OEMLabel,
 		Size:            constants.OEMSize,
 		Name:            constants.OEMPartName,
@@ -496,8 +489,7 @@ func NewUkiInstallElementalPartitions(spec *v1.InstallUkiSpec) v1.ElementalParti
 		MountPoint:      constants.OEMDir,
 		Flags:           []string{},
 	}
-
-	pt.Persistent = &v1.Partition{
+	spec.Partitions.Persistent = &v1.Partition{
 		FilesystemLabel: constants.PersistentLabel,
 		Size:            constants.PersistentSize,
 		Name:            constants.PersistentPartName,
@@ -505,7 +497,8 @@ func NewUkiInstallElementalPartitions(spec *v1.InstallUkiSpec) v1.ElementalParti
 		MountPoint:      constants.PersistentDir,
 		Flags:           []string{},
 	}
-	return pt
+
+	return spec
 }
 
 // ReadUkiInstallSpecFromConfig will return a proper v1.InstallUkiSpec based on an agent Config
@@ -614,7 +607,8 @@ func ReadSpecFromCloudConfig(r *Config, spec string) (v1.Spec, error) {
 	}
 	viper.SetConfigType("yaml")
 	viper.ReadConfig(strings.NewReader(ccString))
-	vp := viper.Sub(spec)
+	// Change the spec into normal spec without the '-uki' so we load the same vars from the config as the normal actions
+	vp := viper.Sub(strings.ReplaceAll(spec, "-uki", ""))
 	if vp == nil {
 		vp = viper.New()
 	}