Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record headers not passed to custom serde when deserializing key #634

Open
4 tasks done
twinprime opened this issue Oct 25, 2024 · 1 comment
Open
4 tasks done

Record headers not passed to custom serde when deserializing key #634

twinprime opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
area/serde Serialization & Deserialization (plugins) status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/bug Something isn't working

Comments

@twinprime
Copy link

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running main-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

When ConsumerRecordDeserializer invoke Serde.Deserializer.deserialize, it pass in an empty list of RecordHeader instead of the actual RecordHeaders

var deserResult = keyDeserializer.deserialize(new RecordHeadersImpl(), rec.key().get())

My custom Serde require the record headers to find the encoding schema from our schema registry.

Expected behavior

ConsumerRecordDeserializer should pass the record headers to the deserialize function like what it does when deserializing values.

var deserResult = keyDeserializer.deserialize(new RecordHeadersImpl(rec.headers()), rec.key().get())

Your installation details

I reference the main branch code above:

var deserResult = keyDeserializer.deserialize(new RecordHeadersImpl(), rec.key().get());

Steps to reproduce

Problem should be obvious from the actual source code quoted above.

Screenshots

No response

Logs

No response

Additional context

No response

@twinprime twinprime added status/triage Issues pending maintainers triage type/bug Something isn't working labels Oct 25, 2024
@kapybro kapybro bot added status/triage/manual Manual triage in progress area/serde Serialization & Deserialization (plugins) status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 25, 2024
Copy link

Hi twinprime! 👋

Welcome, and thank you for opening your first issue in the repo!

Please wait for triaging by our maintainers.

As development is carried out in our spare time, you can support us by sponsoring our activities or even funding the development of specific issues.
Sponsorship link

If you plan to raise a PR for this issue, please take a look at our contributing guide.

@Haarolean Haarolean self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serde Serialization & Deserialization (plugins) status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants