Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include IdleTimeoutFilter conditionally based on X-Accept-Commands in wseb #572

Open
jitsni opened this issue May 12, 2016 · 0 comments
Open
Labels
bug p2 triage Needs to be triaged

Comments

@jitsni
Copy link
Contributor

jitsni commented May 12, 2016

Gateway's IdleTimeoutFilter sends PONGs in writer is idle. Some older clients (like .NET 4.0) don't understand PONGs. The proposal is to use X-Accept-Commands: pong to include IdleTimeoutFilter and thus it becomes conditional.

Newer clients need to send X-Accept-Commands:pong and process PONGs. Older clients don't get PONGs (they rely on NOOP command) as they don't send X-Accept-Commands:pong

We need to update x-kaazing-idle-timeout specification accordingly and add some specification tests for wseb.

@sbadugu sbadugu added the bug label Nov 4, 2016
@sbadugu sbadugu added the p2 label Nov 16, 2016
@robinzimmermann robinzimmermann added the triage Needs to be triaged label Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 triage Needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants