Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Improvement needed for the UI of Media permission card #24

Open
kaali001 opened this issue Oct 29, 2024 · 9 comments
Open

issue: Improvement needed for the UI of Media permission card #24

kaali001 opened this issue Oct 29, 2024 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kaali001
Copy link
Owner

Describe the bug
As of now the Media permission card doesn't looks great, It needs some improvement.

To Reproduce
Steps to reproduce the behavior:

  1. Go to chat page
  2. Click on join button
  3. See the media permission card

Below is the sample of Media permission card in the Figma design as per expected UI , But its only a sample so you can make changes
according to your creativity, but please inform about the final design you are making before making a PR.

Figma Design Link

@kaali001 kaali001 added bug Something isn't working enhancement New feature or request labels Oct 29, 2024
@Suman-Jyoti-Phukan
Copy link
Contributor

Hello @kaali001, sorry for responding late. I was quite busy past few days, you can assign me the task or you can open the issue for others. Thank you.

@kaali001
Copy link
Owner Author

kaali001 commented Nov 3, 2024

@Suman-Jyoti-Phukan, Go ahead.

@kaali001
Copy link
Owner Author

kaali001 commented Nov 9, 2024

Any update ?

@Suman-Jyoti-Phukan
Copy link
Contributor

Hey,Sorry!! The last couple of weeks were quite hectic for me. I'm working on it and most probably i'll push the pr tomorrow.

@kaali001
Copy link
Owner Author

Any Update ?

@Suman-Jyoti-Phukan
Copy link
Contributor

Hi @kaali001,

I hope this message finds you well. Apologies for the delay—I’ve been quite occupied with relocating for a new job, which unfortunately delayed my progress on the changes. I’ve now incorporated the updates, and I’d greatly appreciate it if you could take a moment to review them and share your feedback.

Looking forward to hearing your thoughts!

@kaali001
Copy link
Owner Author

kaali001 commented Dec 9, 2024

Hey @Suman-Jyoti-Phukan ,

Great to hear about your progress, And for this issue our requirements have been changed a bit. Actually now we have to take user Name and languages as input so that further it can be used. This part is likely to be implemented on the UserPermisson.tsx component.

It can be modified as given steps :

  1. Change the title Media Access Permissions to something which suits better.
  2. Add a step progress completion bar on below the title , because now it would consist two part:
    • one for taking Input of user's name and A dropdown or multi-select option for users to select the languages they are learning.
    • second part for media permissions (camera and microphone).
  3. Step-based Interaction: The component should display part one first and only after they are filled, activate a "Next" button to proceed to media permissions (camera and microphone).

Acceptance Criteria

  1. User Input for Name:

    • A text input box to collect the user's name.
    • Basic validation to ensure the input is not empty before proceeding.
  2. Preferred Language Selection:

    • A dropdown or multi-select input to let users pick one or more languages they are learning.
    • Provide a list of commonly learned languages (e.g., English, Spanish, French, etc.).
  3. Step-by-Step Flow:

    • On opening the UserPermission popup, display the name and language input fields.
    • Enable the "Next" button only after both fields are filled.
    • On clicking "Next," render the existing media permissions UI for camera and microphone.
  4. UI Enhancements:

    • Maintain a user-friendly and responsive design consistent with the existing UI.
    • Add appropriate error handling and tooltips for invalid input.
  5. State Management:

    • Store the name and selected languages in the state and pass them as props or emit them as events to the parent component for further use.

Proposed Changes to UserPermission

  • Add state variables for userName and preferredLanguages.
  • Update the UI to display the new input fields as the first step.
  • Introduce a step-based flow where the media permission UI is displayed only after completing the first step.
  • Validate user input and manage form state to enable or disable the "Next" button.

@Suman-Jyoti-Phukan
Copy link
Contributor

Hey, can you provide the Figma design for this? I’m currently short on time, and it would be a great help if you could share it. Thanks in advance

@kaali001
Copy link
Owner Author

I have made a sample UI as per requirement , You can fix where ever it needed to implement. check the figma design Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants