Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local gopath #88

Merged
merged 4 commits into from
May 30, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

this commit updates several packages to their
latest version such as cni plugins, rdma cni,
ginkgo, gomega.

in addition update local imports to point to
k8snetworkplumbingwg instead of Mellanox org

Signed-off-by: adrianc <[email protected]>
use gomodules instead.

Signed-off-by: adrianc <[email protected]>
- extend supported version reported by CNI
- set interface index in IPConfig returned from ipam plugin

Signed-off-by: adrianc <[email protected]>
- refactor makefile, clean up unused targets
  remove the use of .gopath, restructure and add
  target description
- update .gitignore file
- add test-image target to buildtest workflow

Signed-off-by: adrianc <[email protected]>
@adrianchiris
Copy link
Collaborator Author

@SchSeba @zeeke did some cleanup PTAL.

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uses: docker/setup-buildx-action@v2

- name: build and test ib-sriov-cni image
run: make test-image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit 3d6a050 into k8snetworkplumbingwg:master May 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants