Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate logging initialization logic in utils.py #1617

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove duplicate logging initialization logic in utils.py #1617

merged 1 commit into from
May 6, 2024

Conversation

yfyeung
Copy link
Collaborator

@yfyeung yfyeung commented May 6, 2024

Since we already have force=True to achieve the same logic, explicitly resetting logging is no longer necessary.

csukuangfj
csukuangfj approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yfyeung yfyeung merged commit 4e97b19 into k2-fsa:master May 6, 2024
203 checks passed
@yfyeung yfyeung deleted the fix/utils branch May 6, 2024 05:00
yfyeung added a commit to yfyeung/icefall that referenced this pull request Aug 9, 2024
@yfyeung
Remove duplicate logging initialization logic in utils.py (k2-fsa#1617)
8041ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfyeung @csukuangfj