Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <Deleting first row> #555

Closed
kreisligaspieler opened this issue Apr 19, 2024 · 1 comment
Closed

[BUG] <Deleting first row> #555

kreisligaspieler opened this issue Apr 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kreisligaspieler
Copy link

Steps to reproduce

Don't know it its a bug or if i did something wrong. If i want to delete the first row, i need to delete the second row!
block RowDeleter oftype RowDeleter {delete: [row 1,];} doesn't do anything, whereas delete: [row 2] deletes the first row. This might be a bug, but could also happen when header: false is set.
Pipeline:
pipeline TestPipeline {
Extractor -> TextFileInterpreter->RangeSelector->CSVInterpreter->ColumnDeleter->RowDeleter->TableInterpreter->Loader;
block Extractor oftype HttpExtractor {url: "https://geo.sv.rostock.de/download/opendata/museen/museen.csv";}
block TextFileInterpreter oftype TextFileInterpreter {encoding: "utf8";}
block RangeSelector oftype TextRangeSelector {lineFrom: 1;}
block CSVInterpreter oftype CSVInterpreter {enclosing: '"';delimiter: ",";}
block RowDeleter oftype RowDeleter {delete: [row 1,];}
block TableInterpreter oftype TableInterpreter {
header: false;
columns: ["latitude" oftype decimal,"longitude" oftype decimal,"uuid" oftype text,"kreis_name" oftype text,"kreis_schluessel" oftype integer,"gemeindeverband_name" oftype text,"gemeindeverband_schluessel" oftype integer,"gemeinde_name" oftype text,"gemeinde_schluessel" oftype integer,"gemeindeteil_name" oftype text,"gemeindeteil_schluessel" oftype integer,"strasse_name" oftype text,"strasse_schluessel" oftype integer,"hausnummer" oftype integer,"hausnummer_zusatz" oftype text,"postleitzahl" oftype integer,"bezeichnung" oftype text,"traeger_bezeichnung" oftype text,"traeger_art" oftype text,"barrierefrei" oftype text,"oeffnungszeiten" oftype text,"telefon_festnetz" oftype text,"telefon_mobil" oftype text,"email" oftype text,"website" oftype text];}
block Loader oftype SQLiteLoader {table: "a"; file: "a.sqlite";}
}

Description

  • Expected: Deleting first row
  • Actual: Nothing happens
@kreisligaspieler kreisligaspieler added the bug Something isn't working label Apr 19, 2024
@TungstnBallon
Copy link
Contributor

I think this is working as intended, albeit a bit confusing.

The RangeSelector, I assume, is supposed to filter out the header-row of the input CSV. However, because Jayvee indices start at 1, this block just passes on its input unmodified. For this reason, the RowDeleter block just deletes the header-row, which doesn't affect the output, because the TableInterpreter doesn't use a header-row.

The solution is to start the RangeSelector at index 2:

block RangeSelector oftype TextRangeSelector {
	lineFrom: 2;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants