-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider less intrusive cargo manifest updating #7
Comments
I just ran into this as an issue. I had a proc macro crate that had like this:
When running bomper, it added Some goals I think should be accomplished as a result of this:
|
I should add that it likely isn't enough to try to ensure that a field such as |
It seems that this is due to calling from_path which calls complete_from_path to fill in missing implicit data. Instead, from_slice can be used to retrieve only the included data. |
I'm leaving this open despite #9. It seems that comments may be removed [from |
#3 brought in the ability to edit cargo manifest files directly. However, extra fields are written to
Cargo.lock
and existing fields get reordered (see 12572ae#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e).I'm not sure how much work it would be to prevent this from happening, but I anticipate that it could be a non-trivial change. In the meantime it should be sufficient to either
by_file
replacement (just like how was done in 0.5.0)I'm not entirely against leaving things as they are but it is something worth considering
The text was updated successfully, but these errors were encountered: