Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the comm package #37

Open
jtpio opened this issue Mar 30, 2023 · 7 comments
Open

Use the comm package #37

jtpio opened this issue Mar 30, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Mar 30, 2023

Problem

It should now be possible to use the new comm package: https://pypi.org/project/comm/

Currently there is a mock for ipykernel here: https://github.com/jupyterlite/pyodide-kernel/tree/main/packages/pyodide-kernel/py/ipykernel

Which hopefully could be removed.

Proposed Solution

Use the comm package so can get rid of one of the mocks.

Additional context

jupyterlite/jupyterlite#18

@jtpio jtpio added the enhancement New feature or request label Mar 30, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 30, 2023

Actually not sure since ipywidgets initially dropped ipykernel, but then added it back in jupyter-widgets/ipywidgets#3749.

@jtpio
Copy link
Member Author

jtpio commented Mar 30, 2023

Hmm looks like the latest ipywidgets releases break widgets in the Pyodide kernel:

image

The latest that seems to work is 8.0.4:

image

@jtpio
Copy link
Member Author

jtpio commented Mar 30, 2023

The latest that seems to work is 8.0.4:

cc @martinRenou who might know if this is related to a change in ipywidgets in 8.0.5 or 8.0.6.

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 30, 2023 via email

@jtpio
Copy link
Member Author

jtpio commented Aug 2, 2023

@martinRenou looks like the 8.1.0 release of package of widgets means we could start using the comm package here? https://github.com/jupyter-widgets/ipywidgets/releases/tag/8.1.0

Which would help fix jupyter-widgets/ipywidgets#3819

@martinRenou
Copy link
Member

Yes!

@bollwyvl
Copy link
Contributor

bollwyvl commented Aug 3, 2023

Better do something, because jupyter-widgets/ipywidgets#3811 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants