Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show console error in a full JupyterLab #32

Open
bollwyvl opened this issue Mar 15, 2023 · 2 comments
Open

Don't show console error in a full JupyterLab #32

bollwyvl opened this issue Mar 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bollwyvl
Copy link
Contributor

Problem

Starting a full JupyterLab 3.6-based application with jupyterlite-pyodide-kernel shows the (harmless) console error:

Shared module @jupyterlite/server doesn't exist in shared scope default

Harmless, but annoying.

Proposed Solution

???

Additional context

things tried

  • make all the stuff optional
    • this happens at import time, before disabled is checked, so can't be solved with token dependencies,
  • maybe we just ship the labextension disabled by default.
    • jupyter labextension disable @jupyterlite/pyodide-kernel-extension
      • still gets loaded by webpack machinery (maybe this is fixed in 4?)
  • ???
@bollwyvl bollwyvl added the enhancement New feature or request label Mar 15, 2023
@jtpio
Copy link
Member

jtpio commented Mar 16, 2023

Not sure it's worth looking into this for now. We know this kernel is not meant to be used with JupyterLab at least for now.

Also folks usually create a separate environment for their JupyterLite site, not sure the intent it to also be able to use JupyterLab?

@bollwyvl
Copy link
Contributor Author

folks usually create a separate environment

As mentioned elsewhere, a JupyterLite site builder UI, would be a "normal" labextension, and would want to be installed in an environment which had all the other packages installed, as the sys.prefix stuff done by a real package manager is so important to keeping everything working.

I'm thinking that would not depend on any @jupyterlite/ npm packages, and very probably could be based on ipywidgets. Longer con, this could also run in e.g. pyodide-kernel, which is a ticket i've been meaning to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants