Basic support for renaming the RTC session #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really working for now.
Also we'll probably want to rename the existing files for the other peers, instead of creating new ones with new names. |
|
Posting this PR here as reference as it might be relevant when we resume work here: jupyterlab/jupyterlab#11197 |
|
Closing as this would likely have to be implemented in https://github.com/jupyterlite/jupyterlab-webrtc-docprovider now (or take a different approach). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes jupyterlite/jupyterlab-webrtc-docprovider#20
Code changes
Implement simple logic to rename a file, and continue the RTC session seamlessly.
User-facing changes
Users should be able to rename a file. However since the files are distributed (everyone has a copy in indexeddb), users must explicitly save the notebook to get a copy.
Backwards-incompatible changes