Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC: File Changed dialog #19

Open
jtpio opened this issue Jul 15, 2021 · 1 comment
Open

RTC: File Changed dialog #19

jtpio opened this issue Jul 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jtpio
Copy link
Member

jtpio commented Jul 15, 2021

Description

The second user opening a document with RTC enabled might get this popup when opening a file:

image

Reproduce

Testing locally with http://localhost:5000/lab/?room=1234

  • In the first window, open Untitled.ipynb
  • In a private window or other browser, open Untitled.ipynb

Expected behavior

Opening the file should be smooth without requiring the user to "Overwrite" the document.

Context

Follow-up to jupyterlite/jupyterlite#109

@jtpio jtpio added the bug Something isn't working label Jul 15, 2021
@jtpio
Copy link
Member Author

jtpio commented Dec 21, 2022

Transferring to https://github.com/jupyterlite/jupyterlab-webrtc-docprovider which is where the doc provider is now implemented: https://github.com/jupyterlite/jupyterlab-webrtc-docprovider

@jtpio jtpio transferred this issue from jupyterlite/jupyterlite Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant