Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another provider #13

Open
jtpio opened this issue Nov 4, 2024 · 1 comment
Open

Add another provider #13

jtpio opened this issue Nov 4, 2024 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Nov 4, 2024

As a follow-up to #10 and to validate the approach, it would be interesting to add support for another provider, for example OpenAI.

@brichet
Copy link
Collaborator

brichet commented Nov 5, 2024

We'll probably have to handle it a bit differently for other providers than MistralAI.

I looked a bit into openAi and Groq providers, for example, and it seems that the options (apiKey, ...) are not updated after the initialization. We probably need to create a new instance every time a setting change.
In the long run we may want a dedicated settings panel that is validated on purpose, and not on every change.

For MistalAI, the API "client" is instantiated for each request, that's why the updated options are taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants