Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should style/index.js import index.css instead of base.css ? #215

Open
Carreau opened this issue Apr 11, 2022 · 3 comments
Open

Should style/index.js import index.css instead of base.css ? #215

Carreau opened this issue Apr 11, 2022 · 3 comments

Comments

@Carreau
Copy link

Carreau commented Apr 11, 2022

I have no clue, maybe I[m doing things wrong,]
but any modif I do to index.css of an extension have no effect.
It does if I apply them to base... that is unless I cahnge style/index.js to import from index and not base.

@welcome
Copy link

welcome bot commented Apr 11, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval
Copy link
Member

The index.css/index.js mechanism comes from difficulties to tree shake styles in JupyterLab.

Long story short, the practice is to keep things as in this cookiecutter (aka index.css and index.js import base.css). And place your style in base.css.

@Carreau
Copy link
Author

Carreau commented Apr 12, 2022

Ok, I'll see if I can make a pull request that explain this in index.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants