-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Local Development with Kubernetes with Docker Desktop #3158
base: main
Are you sure you want to change the base?
Support Local Development with Kubernetes with Docker Desktop #3158
Conversation
When I run python deploy.py docker-desktop I get the error
@manics could you point me to the configuration that I'm missing? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be
mybinder.org-deploy/config/staging.yaml
Lines 136 to 140 in 9a88e71
static: | |
ingress: | |
hosts: | |
- static.staging.mybinder.org | |
- static.gke2.staging.mybinder.org |
deploy.py
Outdated
@@ -437,6 +437,7 @@ def main(): | |||
"release", | |||
help="Release to deploy", | |||
choices=[ | |||
"docker-desktop", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to local
or something similar? I don't think this should be specific to docker-desktop, e.g. it should work with a local k3s/microk8s etc. It also means we could run this in GitHub CI using https://github.com/jupyterhub/action-k3s-helm which will allow us to test some changes in PRs instead of having to deploy to staging first.
030b95a
to
3a41e77
Compare
Fixes File "/usr/local/lib/python3.11/site-packages/google/auth/_default.py", line 691, in default raise exceptions.DefaultCredentialsError(_CLOUD_SDK_MISSING_CREDENTIALS) google.auth.exceptions.DefaultCredentialsError: Your default credentials were not found. To set up Application Default Credentials, see https://cloud.google.com/docs/authentication/external/set-up-adc for more information.
c787d8e
to
c2f8078
Compare
57b9030
to
2a6514a
Compare
for more information, see https://pre-commit.ci
Thanks @manics for the feedback. I fixed the previously mentioned Following the provided documentation, the user should be able to
At the moment, the user will get the following error
This should be solved by changing |
I try using binderhub:
config:
BinderHub:
hub_url: http://jupyterhub.localhost to fix the @manics do you have a suggestion? |
I don't think we should recommend modifying the hosts file, it should be possible to either rely on
|
for localhost.
and overwrite Helm chart with the provided IP address.
for more information, see https://pre-commit.ci
In 2a6514a, the launch requests produces the following log in the
My understanding is that the Define
The
Based on https://stackoverflow.com/a/16235349/1802726, the error is because of missing Linux kernel modules that I'm assuming are not available on Docker Desktop. @manics does this looks good for you? Can we merge? I will try to test on my GNU/Linux machine next week. |
No description provided.