[Breaking changes] Update hyper from 0.14 to 1.0

[junkurihara]

rust-rpxy currently depends on hyper of version 0.14.x. hyper project is planning to release version 1.0.x shortly and already released 1.0.0-rc.x.

The version up involves a lot of breaking changes, so we need to rethink the architecture of rpxy to support the brand new version of hyper.

[junkurihara]

hyper 1.0 was published yesterday with tons of drastic changes of its APIs. In my different project with hyper, I already tested the migration flow from 0.1.4 to 1.0, and the migrated project works flawlessly at this point.

However, in rpxy, it takes time for the migration since the structure is more complicated. Also, we should wait for upgrades of the hyper-rustls with hyper-1.0. or change our tls connector to backend servers to hyper-tls that uses native tls module.

We also should use hyper-util to handle both http/1.1. and http/2 connections, and have to change handling of h3 connections as well.

[paulocoghi]

Also, we should wait for upgrades of the hyper-rustls with hyper-1.0. or change our tls connector to backend servers to hyper-tls that uses native tls module.

Wait for upgrades of the hyper-rustls with hyper-1.0 seems to be the better option here.

[junkurihara]

Hi Paulo,

Yes, I agree with you. It makes sense.
Also a draft pull-request was just submitted to its repo, and we hope it will be merged to the repo.

[junkurihara]

I am preparing to release 0.7.0-alpha.0 with support of native-tls instead of rustls for connection with backend applications. In my environment, native-tls works flawlessly at this point.

I will, of course, support again rustls backend connection as the default feature when hyper-rustls with hyper-1.0 is out.

[junkurihara]

Currently we have a problem on websocket connection: it always says:

upgrade expected but low level API in use

to poll the Upgraded from OnUpgrade in response..

This might relate to hyperium/hyper#1752. However, our code uses hyper::upgrade::on and stream io implementing Sync...

The problem happens here:

rust-rpxy/rpxy-lib/src/message_handler/handler_main.rs

Lines 226 to 232 in 7e37b81

	let res_on_upgrade = hyper::upgrade::on(&mut res_backend);
	self.globals.runtime_handle.spawn(async move {
	let mut response_upgraded = TokioIo::new(res_on_upgrade.await.map_err(|e| {
	error!("Failed to upgrade response: {}", e);
	RpxyError::FailedToUpgradeResponse(e.to_string())
	})?);

[paulocoghi]

I believe that, for most of the users, it doesn't matter so much the internal implementations.

What I'm trying to say is that, if you believe that using only native-tls for now is good enough, it is good for the users as well.

[junkurihara]

Hi Paulo,

Yes I totally agree with you. Also I am not sure that how many users needs TLS connection to backend applications (I don't use it lol)

However, from dev side, I think we should make rustls default since native-tls doesn't support TLSv1.3.

[junkurihara]

Currently we have a problem on websocket connection: it always says:

upgrade expected but low level API in use

to poll the Upgraded from OnUpgrade in response..

This might relate to hyperium/hyper#1752. However, our code uses hyper::upgrade::on and stream io implementing Sync...

The problem happens here:

rust-rpxy/rpxy-lib/src/message_handler/handler_main.rs

Lines 226 to 232 in 7e37b81

	let res_on_upgrade = hyper::upgrade::on(&mut res_backend);
	self.globals.runtime_handle.spawn(async move {
	let mut response_upgraded = TokioIo::new(res_on_upgrade.await.map_err(|e| {
	error!("Failed to upgrade response: {}", e);
	RpxyError::FailedToUpgradeResponse(e.to_string())
	})?);

That's a bug which was just fixed :-) hyperium/hyper-util@1427d1b

[paulocoghi]

That's a bug which was just fixed :-)

Good news!

[junkurihara]

hyper-rustls v0.26 supporting hyper v1.0 was just integrated with rpxy #137 . Yet rustls v0.22 is not supported, I believe hyper v1.0 integration was almost done!

[junkurihara]

Should we release 0.7.0 without waiting for releases of new quinn and s2n-quic supporting rustls-0.22?

[paulocoghi]

For our usage scenario, we can wait.

[junkurihara]

Recently I've checked the code of rustls-0.22 and s2n-quic-rustls based on the previous version of rustls. As long as I read their code, IMHO, quite huge time is required for s2n-quic developers to update s2n-quic-rustls using the newest version of rustls.

So I think I should release rpxy-0.7 without waiting for rustls-0.22 and its related updates. I will do that shortly after some load-tests with my servers.

[paulocoghi]

I will do that shortly after some load-tests with my servers.

I can't wait for the results!