Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate c-icon #74

Open
dlemm opened this issue Nov 14, 2023 · 0 comments
Open

Investigate c-icon #74

dlemm opened this issue Nov 14, 2023 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@dlemm
Copy link
Member

dlemm commented Nov 14, 2023

In the c-icon there is a not (always) working condition. We should investigate if this is still necessary. In a project svgs sometimes were rendered as an image instead of a svg.
I removed it with just use "utils/svg/icon" because there it is also possible to render the icon as an image.
The whole c-icon, asset, svg structure and what renders what and when is kind of confusing. We should write a short documentation for it.

{{- with partial "utils/asset" (dict
  "context" $params
  "globals" $globals
  "options" (dict "class_name" $class)
) -}}
  {{- . -}}
{{- else -}}
  {{- partial "utils/svg/icon" (dict
    "context" $params
    "globals" $globals
    "options" (dict "class_name" $class)
  ) -}}
{{- end -}} 
@dlemm dlemm added bug Something isn't working documentation Improvements or additions to documentation labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant