Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sum(::AbstractArray{<:AbstractMutable}; dims) #310

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Fix sum(::AbstractArray{<:AbstractMutable}; dims) #310

merged 4 commits into from
Oct 16, 2024

Conversation

odow
Copy link
Member

@odow odow commented Oct 15, 2024

Closes #309

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (3f811de) to head (f4bdeb3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   90.41%   90.42%           
=======================================
  Files          22       22           
  Lines        2222     2224    +2     
=======================================
+ Hits         2009     2011    +2     
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow requested a review from blegat October 15, 2024 03:03
@blegat
Copy link
Member

blegat commented Oct 15, 2024

Any reason you used missing instead of :

src/dispatch.jl Outdated Show resolved Hide resolved
src/dispatch.jl Outdated Show resolved Hide resolved
@odow odow merged commit 5705dc3 into master Oct 16, 2024
11 checks passed
@odow odow deleted the od/sum-dims branch October 16, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sum with init and dims
2 participants