copy for BigInt, BigFloat and Rational

[nsajko]

Fixes #163.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cc20ad) 89.66% compared to head (aa79211) 89.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   89.66%   89.72%   +0.06%     
==========================================
  Files          23       23              
  Lines        2157     2171      +14     
==========================================
+ Hits         1934     1948      +14     
  Misses        223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nsajko]

The failing Aqua lint is unrelated (Aqua is complaining about missing compat bounds for dependencies).

[odow]

The failing Aqua lint is unrelated (Aqua is complaining about missing compat bounds for dependencies).

I can fix this; #239

[odow]

Looks okay to me, but this needs @blegat's review.

[blegat]

I think you need to keep the local to avoid the performance issue of closures

[nsajko]

No, it's fine:

julia> import MutableArithmetics, LinearAlgebra; const MA = MutableArithmetics;

julia> x = BigFloat[1, 3];

julia> y = BigFloat[3, 1];

julia> buf = MA.buffer_for(LinearAlgebra.dot, typeof(x), typeof(y))
MutableArithmetics.DotBuffer{BigFloat}(NaN, NaN, NaN, NaN)

julia> import MutableArithmetics, LinearAlgebra; const MA = MutableArithmetics;

julia> x = BigFloat[1, 3];

julia> y = BigFloat[3, 1];

julia> buf = MA.buffer_for(LinearAlgebra.dot, typeof(x), typeof(y));

julia> using JET

julia> @report_opt MA.buffered_operate_to!(buf, big(1.2), LinearAlgebra.dot, x, y)
No errors detected

julia> @report_call MA.buffered_operate_to!(buf, big(1.2), LinearAlgebra.dot, x, y)
No errors detected

TBH I'm not even completely sure why I used local back when I wrote the code. I think I may have simply considered it good style to use local with any local variable. I don't use local at all any more.

[nsajko]

Besides, the tests would have caught any extra allocations.

[blegat]

Thanks!