-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add new solver CATrustRegionMethod.jl #3900
Conversation
Add a new row for the CAT solver to the table in `docs/src/installation.md`
Hi @fadihamad94 (and, I see, @ohinder 🇳🇿), we have a checklist for this that needs to be completed before merging: Basic
Documentation
Optional
|
HI @odow, below is the checklist: Basic
Documentation
Optional
|
Thanks! The requirement to have it registered is a hard-requirement. You're going to struggle to get |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3900 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 43 43
Lines 6043 6043
=======================================
Hits 6018 6018
Misses 25 25 ☔ View full report in Codecov by Sentry. |
Hi @odow , thank you for the comment. We updated the package name and registered it JuliaRegistries/General#121222. |
Great! New packages take three days to merge in case someone wants to comment on the name, but it looks okay to me. |
I guess I should update the checklist: can you add GitHub actions to test the package? You should also add TagBot: https://github.com/jump-dev/JuMP.jl/blob/master/.github/workflows/TagBot.yml |
@odow done. I added GitHub actions to test the package and added TagBot. |
Add CATrustRegionMethod solver to the list of available JuMP solvers.
Adding a new solver to the documentation:
Add a new row for the CATrustRegionMethod solver to the table in
docs/src/installation.md