Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Classifiers tutorial #3569

Merged
merged 11 commits into from
Nov 15, 2023
Merged

[docs] Classifiers tutorial #3569

merged 11 commits into from
Nov 15, 2023

Conversation

jd-foster
Copy link
Collaborator

@jd-foster jd-foster commented Nov 10, 2023

Adding this initial draft here to get any feedback.

Preview https://jump.dev/JuMP.jl/previews/PR3569/tutorials/nonlinear/classifiers/

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b13812d) 98.38% compared to head (48d6d0e) 98.38%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3569   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          37       37           
  Lines        5624     5629    +5     
=======================================
+ Hits         5533     5538    +5     
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/src/tutorials/nonlinear/classifiers.jl Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
docs/src/tutorials/nonlinear/classifiers.jl Outdated Show resolved Hide resolved
@odow odow marked this pull request as ready for review November 12, 2023 04:49
@odow
Copy link
Member

odow commented Nov 14, 2023

Is it ready for me to take another look? Or do you still have more plans

@jd-foster
Copy link
Collaborator Author

Please. No, this is as much as I want to do.

@odow
Copy link
Member

odow commented Nov 15, 2023

Okay, @jd-foster I made a number of changes, mainly to simplify the code (returning a classifier function) and simplify the plotting calls (at the expense of less control over the colors, etc).

@jd-foster
Copy link
Collaborator Author

Thanks @odow , looks good to me.

@jd-foster
Copy link
Collaborator Author

(though a bit sad that my carefully curated colour design has been thrown out 😄)

@odow
Copy link
Member

odow commented Nov 15, 2023

I have wondered about standardizing all of the plots used across the documentation...

@odow odow merged commit 882eebe into master Nov 15, 2023
12 checks passed
@odow odow deleted the jdf/docs-svm branch November 15, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants