Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _DoNotConvertSet Public #3549

Closed
pulsipher opened this issue Oct 27, 2023 · 2 comments · Fixed by #3552
Closed

Make _DoNotConvertSet Public #3549

pulsipher opened this issue Oct 27, 2023 · 2 comments · Fixed by #3552

Comments

@pulsipher
Copy link
Contributor

We need this for DisjunctiveProgramming. We need to intercept the add_constraint call be dispatching on our expression type along with the set (_DoNotConvertSet), but this is not public. Sorry I failed to bring this up in #3530.

@odow
Copy link
Member

odow commented Oct 27, 2023

Ha, I was expecting this, just not so quickly: #3530 (comment)

Open to bike shed better names:

  • IgnoreModelConvertSet, DoNotModelConvertSet...

@odow
Copy link
Member

odow commented Oct 29, 2023

Here you go: #3552

@odow odow closed this as completed in #3552 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants