Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supports_constraint(::Optimizer, ::Type{VariableIndex}, ::Type{ZeroOne}) #242

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

odow
Copy link
Member

@odow odow commented Oct 23, 2024

Closes #241

I didn't test locally, so let's see what the impact is.

@odow
Copy link
Member Author

odow commented Oct 23, 2024

@joaquimg now I remember. I originally wanted to test simplex/ipm with/out presolve. Not really for HiGHS.jl, mainly for upstream verification. But because HiGHS ignores binaries with simplex/ipm, I added that in so we would skip the relevant tests.

I've removed the simplex/ipm tests. It's not our job to test every combination of options.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (201cbed) to head (2510622).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   99.77%   99.77%   -0.01%     
==========================================
  Files           1        1              
  Lines        1353     1352       -1     
==========================================
- Hits         1350     1349       -1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit c7cf7ec into master Oct 23, 2024
10 checks passed
@odow odow deleted the od/fix-support-integer branch October 23, 2024 02:13
@joaquimg
Copy link
Member

That makes sense, it was really weird to have that check only in HiGHS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

set_binary notworking if solver = ipm
2 participants