Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$verifiedClaims is no array but an object #423

Open
tillweb opened this issue Jul 22, 2024 · 0 comments
Open

$verifiedClaims is no array but an object #423

tillweb opened this issue Jul 22, 2024 · 0 comments

Comments

@tillweb
Copy link

tillweb commented Jul 22, 2024

Since member $verifiedClaims is an (deserialized json) object and no associative array it should not be declared as array [].

protected $verifiedClaims = [];

e.g.

var $verifiedClaims;

or

private ?object $verifiedClaims;

I assume an default initialization is not necessary but this needs to be checked by the author.

Since the member is overwritten by on object always before use, it does not matter in terms of functionality but it is just not nice.

@tillweb tillweb changed the title $verifiedClaims is an object no array $verifiedClaims is no array but an object Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant