feat: JAAS groups schema and CRUD #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Just taking a brief looking at this,
|
kian99
reviewed
Sep 11, 2024
hmlanigan
reviewed
Sep 12, 2024
| } | ||
|
|
||
| // Read the group from JAAS | ||
| group, err := resource.client.Jaas.ReadGroup(ctx, state.UUID.ValueString()) |
There was a problem hiding this comment.
I'm wondering how this will work out. It's unexpected to read based off of a computed value from the plan, rather than a value required to be set.
pkulik0
force-pushed
the
jaas-groups
branch
from
1e11fd1
to
1f76ce7
Compare
pkulik0
force-pushed
the
jaas-groups
branch
from
1f76ce7
to
5b5105a
Compare
pkulik0
force-pushed
the
jaas-groups
branch
from
5b5105a
to
bcf709c
Compare
hmlanigan
reviewed
Sep 17, 2024
hmlanigan
approved these changes
Sep 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a resource for jaas groups, updates the jaas client to include required functions and covers the added functionality with tests.
CSS-9770 / CSS-9772
Type of change
jimm-go-sdk, andjimmin jaas integration test