New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you remove Lock #35

Open

maczam opened this issue Jun 10, 2020 · 1 comment

maczam commented Jun 10, 2020 •

edited

Loading

In the process of using ratelimit,there's a lock in the source code . can you replace it with atomic?

func (tb *Bucket) TakeAvailable(count int64) int64 {
tb.mu.Lock()
defer tb.mu.Unlock()
return tb.takeAvailable(tb.clock.Now(), count)
}

Author

maczam commented Jun 14, 2020 •

edited

Loading

Similar https://github.com/uber-go/ratelimit https://github.com/maczam/ymratelimit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment