Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also clean up expired tmp dirs #5366

Closed
wants to merge 1 commit into from

Conversation

polyrabbit
Copy link
Contributor

.sys dir is created by gateway once user used it, but it's never deleted automatically. We should clean it up when expired to avoid confusion to users.

Signed-off-by: Changxin Miao <[email protected]>
@zhijian-pro
Copy link
Contributor

The f.Close(mctx) is ok, but I don't think deleting an empty directory is necessary. Because even if you delete the empty directory, it will be created again when needed.

@polyrabbit
Copy link
Contributor Author

OK, closing

@polyrabbit polyrabbit closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants