xattr: add the XattrNoSecurity flag to enable mac os Finder to set ex…

…tended attributes (#5197)
juicedata · Sep 29, 2024 · 4f75f01 · 4f75f01
1 parent 8824126
commit 4f75f01
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 0 deletions.
diff --git a/pkg/meta/utils_darwin.go b/pkg/meta/utils_darwin.go
@@ -17,4 +17,5 @@ const (
 	XattrCreateOrReplace = 0
 	XattrCreate          = sys.XATTR_CREATE
 	XattrReplace         = sys.XATTR_REPLACE
+	XattrNoSecurity      = sys.XATTR_NOSECURITY
 )
diff --git a/pkg/meta/utils_linux.go b/pkg/meta/utils_linux.go
@@ -17,4 +17,5 @@ const (
 	XattrCreateOrReplace = 0
 	XattrCreate          = sys.XATTR_CREATE
 	XattrReplace         = sys.XATTR_REPLACE
+	XattrNoSecurity      = 8
 )
diff --git a/pkg/meta/utils_windows.go b/pkg/meta/utils_windows.go
@@ -30,4 +30,5 @@ const (
 	XattrCreateOrReplace = 0
 	XattrCreate          = 1
 	XattrReplace         = 2
+	XattrNoSecurity      = 8
 )
diff --git a/pkg/vfs/vfs.go b/pkg/vfs/vfs.go
@@ -1072,6 +1072,10 @@ func (v *VFS) SetXattr(ctx Context, ino Ino, name string, value []byte, flags ui
 		err = v.Meta.SetFacl(ctx, ino, aclType, rule)
 		v.invalidateAttr(ino)
 	} else {
+		// ignore NoSecurity flag
+		if runtime.GOOS == "darwin" && (flags&meta.XattrNoSecurity) != 0 {
+			flags &= ^uint32(meta.XattrNoSecurity)
+		}
 		err = v.Meta.SetXattr(ctx, ino, name, value, flags)
 	}
 	return