-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic webhook notification #295
Comments
Oh this is a great idea. I took a whack at this, let me know your thoughts @zdwolfe : https://github.com/juftin/camply/blob/5c747a1cacfe44ae04f8c6108d81853bcec173ce/docs/command_line_usage.md#send-a-webhook-notification |
Pydantic made this super easy to dump the camply.containers.AvailableCampsite objects into JSON: camply/camply/notifications/webhook.py Lines 43 to 59 in 5c747a1
|
Thanks! I left minor feedback in #296 (review) |
Love this idea! |
🎉 This issue has been resolved in version 0.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Here's the relevant documenation: https://juftin.com/camply/command_line_usage/#send-a-webhook-notification |
Is your feature request related to a problem? Please describe.
As the administrator of an application in the local travel space, I want
camply
to send a webhook (HTTP/POST
) to a configuration-specified URL with configuration-specified headers and a JSON representation of the campsite so my application can programmatically handle the notification.Describe the solution you'd like
When
WEBHOOK_URL
,WEBHOOK_HEADERS
, and--notifications webhook
are specified, the notification should be POST'ed to theWEBHOOK_URL
with theWEBHOOK_HEADERS
. The request body should be JSON with machine-readable fields (example, dates should be epoch timestamps or other common time format).Something like:
and
Describe alternatives you've considered
The open Discord PR is close, as is Slack, but the fields are human friendly or formatted, not generically machine-readable.
Additional context
If this sounds reasonable to you, I am willing to contribute a PR.
The text was updated successfully, but these errors were encountered: