Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second consecutive multi-part (TP DT) Memory Access write fails #76

Open
sbaconbits opened this issue May 21, 2024 · 0 comments
Open

Second consecutive multi-part (TP DT) Memory Access write fails #76

sbaconbits opened this issue May 21, 2024 · 0 comments

Comments

@sbaconbits
Copy link

My test case performs the following operations on a j1939.MemoryAccess
object:

  • write len 14
  • read len 14
  • write len 14
  • read len 14

The second write fails to complete.

In the function J1939_21::async_job_thread a message in the state
SENDING_IN_CTS has equal values for 'next_packet_to_send' and 'num_packages'
which I believe should not happen.

Later calls to J1939_21::send_pgn() detects there is a message with the same hash in the
_snd_buffer and returns False.

I believe the fix is to delete the buffer from the send dictionary (_snd_buffer) if
'next_packet_to_send' and 'num_packages' are equal after the call to __send_tp_dt.

With all that being said I am new to using this library and perhaps I'm using
it incorrectly.

Thanks for your time,
Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant