Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code comment might not be correct in ElectronicControlUnit.subscribe #65

Open
grant-allan-ctct opened this issue Dec 9, 2023 · 0 comments

Comments

@grant-allan-ctct
Copy link
Collaborator

grant-allan-ctct commented Dec 9, 2023

I have been experimenting with using an ElectronicControlUnit without any ControllerApplication, a technique which is mentioned here (and also the first Quick start example on the front page).

There is a line of commentary in the subscribe function saying:

Note: TP.CMDT will only be received if the destination address is bound to a controller application.

Looking at the code in j1939_21.py lines 500-518 (and comparable code in j1939_22.py), and backed up by my experiments, I think that the comment should probably say:

Note: TP.CMDT will only be received if device_address is not None.

I have found it possible to receive TP without using a CA, by passing a device_address argument to subscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant